On Tue 09-06-15 15:27:17, Cyril Hrubis wrote:
> Hi!
> 
> Ccing kernel mm devs.
> 
> > Huge Zero Page feature has been added in kernel-3.17, so I draft these
> > testcase to cover it in LTP.
> > 
> > hzp01.sh: Checking if the HZP feature works well.

Does this even work? What would be a difference between thp zero page
and a regular zero pages? Both read faults should use a form of a zero
page AFAICS.

> > hzp02.sh: Checking if the HZP feature peformed well.

What does this mean? Just that thp_zero faults are faster? How do you
guarantee reproducibility (e.g. zero_thp disabled performing repeatably)

> > hzp03.sh: Do Huge Zero Page stress test.

I fail to see what is this testing actually.

[...]
> > +export TCID="hzp03"
> > +export TST_TOTAL=1
> > +
> > +. test.sh
> > +. hzp_lib.sh
> > +
> > +MAX_LOOP=2000
> > +RC=0
> > +
> > +hzp_stress_test()
> > +{
> > +   for ((i = 0; i < $MAX_LOOP; i++))
> > +   {
> > +           hzp_on || RC=$?
> > +           hzp_off || RC=$?
> > +   }
> > +
> > +   if [ $RC -eq 0 ]; then
> > +           tst_resm TPASS "finished running the stress test."
> > +   else
> > +           tst_resm TFAIL "please check log message."
> > +   fi
[...]
> > +hzp_on()
> > +{
> > +   echo 1 >$USE_ZERO_PAGE
> > +   if [ $? -ne 0 ]; then
> > +           tst_brkm TBROK "turn on hzp failed."
> > +   fi
> > +}
> > +
> > +hzp_off()
> > +{
> > +   echo 0 >$USE_ZERO_PAGE
> > +   if [ $? -ne 0 ]; then
> > +           tst_brkm TBROK "turn off hzp failed."
> > +   fi
> > +}
-- 
Michal Hocko
SUSE Labs

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to