Hi!
> Some switches need a while to learn the new assigned address, which make the
> connectivity check failed. Make PING_MAX adjustable to let user can pre-define
> it based on their own environment.
> 
> Signed-off-by: Hangbin Liu <liuhang...@gmail.com>
> ---
>  testcases/network/stress/ns-tools/check_icmpv4_connectivity | 2 +-
>  testcases/network/stress/ns-tools/check_icmpv6_connectivity | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/network/stress/ns-tools/check_icmpv4_connectivity 
> b/testcases/network/stress/ns-tools/check_icmpv4_connectivity
> index 7630aae..2daaea4 100644
> --- a/testcases/network/stress/ns-tools/check_icmpv4_connectivity
> +++ b/testcases/network/stress/ns-tools/check_icmpv4_connectivity
> @@ -47,7 +47,7 @@
>  $trace_logic
>  
>  # The max number of ICMP echo request
> -PING_MAX=10
> +PING_MAX=${PING_MAX:-"10"}

I do not like exposing random shell variables as interface without any
documentation. Can't we just increase the PING_MAX to make it work for
everybody without any extra work?

-- 
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to