* Paolo Bonzini ([email protected]) wrote: > On 08/13/2011 12:28 AM, Mathieu Desnoyers wrote: >>> > +#ifndef __always_inline >>> > +#define __always_inline inline >>> > +#endif >>> > + >> The patch title says "move" here. We need to "reimplement" these under >> the MIT-style license of comiler.h. We cannot just copy from a GPLv2 >> file into a MIT-licensed file. > > Ok, I'll remove the stringify_in_c since we do not really care about it,
Ok > and likely the only one that is not available elsewhere in the public > domain. If you can put a link to the reference public domain implementation in the changelog, it would be fine. I really don't want to get into any licensing issue. You could re-use: http://git.lttng.org/?p=ust.git;a=blob;f=include/ust/bug.h;h=96007c3fb777a5c072f4b6db08151f99dd196026;hb=refs/heads/lttng-ust-2.0 The __always_inline mapping to inline is a no-brainer, but I wonder if it's worthwhile to clobber the namespace with our own define. I think I'd prefer not to put it in compiler.h, and simply replace all __always_inline by : inline __attribute__((always_inline)) in the library source code. Thanks! Mathieu > > Paolo > -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com _______________________________________________ ltt-dev mailing list [email protected] http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
