-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2012-07-31 14:43, David Goulet wrote: > > > Apart from those minor issues, I have two questions about this patch. First, > why is the python module in src/ and not in extras/ ? I consider src/ to be > supported and stable code shipped with the installation and/or in packages. > Also, the src/ directory is the core code of lttng-tools and this module is > more an extra useful tool. > I'm not sure it belongs to extras, since its an actual library that do something and that is installed on the system.
If you do not want it in src, we could create a top level python directory or a binding/python (which allows for other language later on). On the other hand, its a binding of the liblttng-ctl, so having the binding live with the lib directly can be a good idea. We should probably do a quick survey of other projects approach. > Second, _IF_ this goes into src/, please move the tests to the tests/ > directory else we are going to make it self contained in extras/ which is good > right now. > yes, good point. Yannick -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAYL+gACgkQFQrZ7GzHX2rtagCgllef/MlyxLacs1Udta3NB8Y5 WJEAnA5E5zMJ08cLdBMYKjsDhqqIF7BP =j7S+ -----END PGP SIGNATURE-----
_______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
