I'm not sure that's possible. Whether I change them to uint8_t or int8_t, I get 
warnings because they get used with strncpy which wants char. Any idea how to 
solve this?

Marc-André

________________________________
From: [email protected] [[email protected]] on behalf of Simon Marchi 
[[email protected]]
Sent: Friday, 17 January 2014 9:31 PM
To: Marc-André Laperle
Cc: [email protected]
Subject: Re: [lttng-dev] [PATCH] Use uint32_t for 
lttng_viewer_stream.metadata_flag

While you are at it, you could change the char fields as well, since char is 
not exact-width either.


On 17 January 2014 18:47, Marc-Andre Laperle 
<[email protected]<mailto:[email protected]>> wrote:
This struct is meant to be sent over the network so members should be
of exact-width.

Signed-off-by: Marc-Andre Laperle 
<[email protected]<mailto:[email protected]>>
---
 src/bin/lttng-relayd/lttng-viewer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/lttng-relayd/lttng-viewer.h 
b/src/bin/lttng-relayd/lttng-viewer.h
index 1977a43..6330270 100644
--- a/src/bin/lttng-relayd/lttng-viewer.h
+++ b/src/bin/lttng-relayd/lttng-viewer.h
@@ -100,7 +100,7 @@ struct lttng_viewer_session {
 struct lttng_viewer_stream {
        uint64_t id;
        uint64_t ctf_trace_id;
-       int metadata_flag;
+       uint32_t metadata_flag;
        char path_name[LTTNG_VIEWER_PATH_MAX];
        char channel_name[LTTNG_VIEWER_NAME_MAX];
 } __attribute__((__packed__));
--
1.8.3.2


_______________________________________________
lttng-dev mailing list
[email protected]<mailto:[email protected]>
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Reply via email to