----- Original Message ----- > From: "Mathieu Desnoyers" <mathieu.desnoy...@efficios.com> > To: "Philippe Proulx" <ppro...@efficios.com> > Cc: "gbastien+lttng" <gbastien+lt...@versatic.net>, "Matthew Khouzam" > <matthew.khou...@ericsson.com>, "Jeremie > Galarneau" <jga...@efficios.com>, "lttng-dev" <lttng-dev@lists.lttng.org>, > "diamon-discuss" > <diamon-disc...@lists.linuxfoundation.org> > Sent: Wednesday, 29 April, 2020 08:08:04 > Subject: Re: [RFC PATCH CTF 1/3] Clarify that unlisted enum values are > implementation-defined
> ----- On Apr 28, 2020, at 2:51 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> ----- On Apr 28, 2020, at 2:40 PM, Philippe Proulx ppro...@efficios.com >> wrote: >> >>> ----- Original Message ----- >>>> From: "Mathieu Desnoyers" <mathieu.desnoy...@efficios.com> >>>> To: "gbastien+lttng" <gbastien+lt...@versatic.net>, "Matthew Khouzam" >>>> <matthew.khou...@ericsson.com>, >>>> diamon-disc...@linuxfoundation.org, ppro...@efficios.com, "Jeremie >>>> Galarneau" >>>> <jga...@efficios.com> >>>> Cc: "lttng-dev" <lttng-dev@lists.lttng.org>, "Mathieu Desnoyers" >>>> <mathieu.desnoy...@efficios.com> >>>> Sent: Thursday, 23 April, 2020 16:52:24 >>>> Subject: [RFC PATCH CTF 1/3] Clarify that unlisted enum values are >>>> implementation-defined >>> >>>> From: Geneviève Bastien <gbastien+lt...@versatic.net> >>>> >>>> Signed-off-by: Geneviève Bastien <gbastien+lt...@versatic.net> >>>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoy...@efficios.com> >>>> --- >>>> common-trace-format-specification.md | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/common-trace-format-specification.md >>>> b/common-trace-format-specification.md >>>> index fd49e59..f5fea51 100644 >>>> --- a/common-trace-format-specification.md >>>> +++ b/common-trace-format-specification.md >>>> @@ -464,6 +464,9 @@ enum { >>>> } >>>> ~~~ >>>> >>>> +The mappings in the enumeration type do not have to be exhaustive. >>>> +Unlisted values are implementation defined. >>>> + >>> >>> Why not just: >>> >>> An enumeration field can have an integral value which its type does not >>> map to a string. >>> >>> ? >> >> Good point, I will use that wording. > > Geneviève pointed out on IRC that the sentence above is weird. Would the > following convey the right meaning ? > > "An enumeration field can have an integral value for which the associated > enumeration > type does not map to a string." Sure. Phil > > Thanks, > > Mathieu > >> >> Thanks, >> >> Mathieu >> >>> >>> Phil >>> >>>> ### 4.2 Compound types >>>> >>>> Compound are aggregation of type declarations. Compound types include >>>> -- >>> > 2.11.0 >> >> -- >> Mathieu Desnoyers >> EfficiOS Inc. >> http://www.efficios.com > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev