On Mon, 2025-12-01 at 09:38 -0500, Philippe Proulx wrote: > On Mon, Dec 1, 2025 at 4:34 AM MOESSBAUER, Felix via lttng-dev > <[email protected]> wrote: > > > > Hi, > > > > I recently created a babeltrace pull request that adds support to > > create an CTF LTTng index file along the CTF files [1]. > > > > It would be great, if someone could review it. > > Thank you for your pull requests. > > I'll need to look at this in detail, but I'm not against the idea, > especially if it's guarded behind a no-by-default > initialization parameter.
That's how I implemented it. > > That being said: > > • We won't review on GitHub: please submit your change to our Gerrit > Code Review system (<https://review.lttng.org/>). > > I know it's a bit more initial work on your side if you're not > familiar with Gerrit, but the review process will be much easier. > > See <https://review.lttng.org/Documentation/user-upload.html> to learn > how to upload a change. It would be great to add this note to the contributing guide as well. > > For this reason, I'll close the PRs immediately. > > • You'll need to add a few tests to validate your feature. Sure. I will add them as I now known that the feature in general is well received within the babeltrace project > > • I'll deal with the documentation (manual pages) myself. Thanks! > > • Given our current workload before the end of the year, I'm not sure > I'll be able to review this before 2026. No problem. For me it would be great, if you could briefly comment if the chosen interface is OK (boolean input parameter called "create- lttng-index"). By that, I can continue the integration in bt2-ftrace- to-ctf [1] and once the feature becomes officially available I don't need to change the plugin again. [1] https://github.com/siemens/bt2-ftrace-to-ctf/pull/13 Best regards, Felix -- Siemens AG Linux Expert Center Friedrich-Ludwig-Bauer-Str. 3 85748 Garching, Germany
