On Tue, Nov 23, 2010 at 3:32 PM, Doug Currie <[email protected]> wrote: > > On Nov 23, 2010, at 10:08 AM, Hisham wrote: > >> On Tue, Nov 23, 2010 at 11:48 AM, steve donovan >> <[email protected]> wrote: >>> On Tue, Nov 23, 2010 at 3:41 PM, Hisham <[email protected]> wrote: >>>> Is it still broken? We did change it from *a to *l. >>> >>> Yes, the output format is different from md5sum. Doug proposed a >>> pattern that did the right thing whatever the tool. >> >> Okay, the output format is different, but get_md5 handles it >> differently -- I thought the only problem was the linebreak. I tested >> it here using openssl as the md5checker and it seems to work. Did you >> have any problems with 2.0.4-rc1? > > Frankly, I did not try it... but I noticed that the read was deliberately > changed from *l to *a in the past, and assumed it must have been for a good > reason. So, it seems like the safer fix is to change the pattern to avoid the > line ending issue altogether.
Okay, I pushed the change. -- Hisham _______________________________________________ Luarocks-developers mailing list [email protected] http://lists.luaforge.net/cgi-bin/mailman/listinfo/luarocks-developers
