On Fri, Mar 4, 2011 at 17:44, Hisham <[email protected]> wrote: > On Fri, Mar 4, 2011 at 3:43 AM, Robert G. Jakabosky > <[email protected]> wrote: >> When installing from a rockspec that checks out from a git repository, >> LuaRocks removes the '.git' subfolder breaking the cloned git repository. >> This is a problem when there are submodules in a parent git repository that >> need to be pull into during build.
That is one more reason why git submodules are evil and broken and must not be used. I use subtrees instead. >> I have a fork of the lua-http-parser [1] project that I was testing some >> changes on when I ran into this problem. It seems that this wasn't a problem >> with LuaRocks 2.0.4, it only started happening with 2.0.4.1. >> Why is the '.git' subfolder removed? > Ouch. Because someone asked me to remove it. That was me. > Sounded like a good idea, > to avoid bloating .src.rock files. It still does, and I would hate to > have to add a source.keep_git flag or something to the rockspec > format, but if there's no other way to build it properly... Please don't add it. Directory .git should not be inside .src.rock. Alexander. _______________________________________________ Luarocks-developers mailing list [email protected] http://lists.luaforge.net/cgi-bin/mailman/listinfo/luarocks-developers
