Am 22.09.2014 um 16:32 schröbte Gunnar Zötl: > >> Feel free to add to the wiki! Post a link here when you're done, then >> everyone will be able to review and contribute to it. > > I did. The page is available at > > http://luarocks.org/en/Creating_a_Makefile_that_plays_nice_with_LuaRocks > > If I'm off at some point (or all ;) ), I'd appreciate correction.
Nice work! I have some suggestions: 1) You mention `LUA_LIBDIR` but not `LUALIB`, which is the file name of the Lua library. If you need one, you probably need the other as well (on Linux, *BSD, ..., you need neither). And `LUA_BINDIR` is less useful than `LUA` which is the path to the Lua interpreter. 2) There's a typo (s/then/them/) in "These variables are not readily available ...". 3) You don't need GNU Make's `?=` feature to have a LuaRocks Makefile that also works standalone. Variables set on the command line (which LuaRocks uses to pass variables from rockspecs to `make`) always override the settings in the Makefile[1], so a plain `=` is enough. 4) You probably shouldn't put `-c` in `CFLAGS` (LuaRocks doesn't do that either). > > Gunnar Philipp [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html#tag_20_76_13_05 ("Macros defined in the makefile(s) shall not override macro definitions from source 1 or source 2.") ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Luarocks-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/luarocks-developers
