> On 22/12/2015, at 1:33 am, Philipp Janda <[email protected]> wrote:
>
> Two other things: This would probably be a welcome addition to LuaRocks3
> (unfortunately the change isn't backwards compatible), and you can
> implement your changes in a custom fetcher module and provide that as a
> rock as well (so you don't have to run a patched LuaRocks). Have a look
> at the files in `src/luarocks/fetch/`.
Can you just clarify this a little? In your earlier email, you suggested
patching fetch.lua, which is in LR2 and LR3, and here you're talking about LR3,
but "breaking change", and I assume LR3 doesn't have those yet?
So, just to make it clear:
- should do anything at all with LR2, or just migrate locally to LR3 from git?
- are you sure it's a breaking change for LR3? I'm not sure it makes for a
custom fetcher - source.dir seems to be orthogonal to the fetch method, and so,
as you said, the change would go in fetch.lua, and work whether you downloaded
a zip, a git repo or from hg.
If I'm going to try do this, then there's a couple of other things that come to
mind:
- even LR3 doesn't seem to have a git_ssh in fetch/, though there is an
hg_ssh. Why is that?
- It would be nice to store credentials outside of rocks. At the moment, I
have rock files that have
source =
{
url =
"https://<access-token>:[email protected]/<username>/<repo>/archive/master.tar.gz",
dir = "<repo>-master"
}
My secret access token is right there in the rock. I keep the rockspec in the
repo. Not a big problem, because it's a private repo. But it occurred to me
that I might be able to open some of these modules up at some stage - at which
time I'll have to be careful to delete the repo history, or I'll be leaving the
access token (or worse, a username and password in the case of bitbucket) out
in the open. So it would be nice to be able to store these somewhere else.
------------------------------------------------------------------------------
_______________________________________________
Luarocks-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/luarocks-developers
