[
https://issues.apache.org/jira/browse/LUCENENET-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675617#action_12675617
]
George Aroush commented on LUCENENET-172:
-----------------------------------------
Be very careful with this patch. Removing the exception, so that ReadChar()
and BeginToken() don't throw any more will cause a major divergence from the
Java version of Lucene. Those two functions are designed AND documented as
such -- that they throw. In addition, they are public methods. Just look at
the demo code; and you will see how the two methods are used.
In short, this patch is a major divergence and is invalid-- it will effect the
flow of Lucene.Net code, and can break client code that already use those
methods. Please do not deliver.
-- George Aroush
> This patch fixes the unexceptional exceptions ecountered in FastCharStream
> and SupportClass
> -------------------------------------------------------------------------------------------
>
> Key: LUCENENET-172
> URL: https://issues.apache.org/jira/browse/LUCENENET-172
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Ben Martz
> Attachments: lucene_2.3.1_exceptions_fix.patch
>
>
> The java version of Lucene handles end-of-file in FastCharStream by throwing
> an exception. This behavior has been ported to .NET but the behavior carries
> an unacceptable cost in the .NET environment. This patch is based on the
> prior work in LUCENENET-8 and LUCENENET-11, which I gratefully acknowledge
> for the solution. While I understand that this patch is outside of the
> current project specification in that it deviates from the "pure" nature of
> the port, I believe that it is very important to make the patch available to
> any developer looking to leverage Lucene.Net in their project. Thanks for
> your consideration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
