[
https://issues.apache.org/jira/browse/LUCENENET-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776841#action_12776841
]
George Aroush commented on LUCENENET-219:
-----------------------------------------
Hi Nick,
I hope this doesn't turn you off, as this is not my intention at all. Your
contribution to the project is greatly appreciated.
Which test case is this patch addressing? If none, then at this point, I'm not
ready to take any code clean up as it will really make it difficult to do any
delta between the 2 code bases (Java and .NET Lucene). This will specially be
an issue if we hit a defect that requires stepping through the code in a
debugger and comparing execution. It will also impact the next release port as
the delta will interfere.
As discussed in the mailing list, I really have to keep the code change to
minimal to help us debug hard issues if we hit them. In addition, I can't take
a patch that adds a new method which will diverge us away from one of our port
principles: "Lucene.Net is a source code, class-per-class, API-per-API...".
So for now, till when we are at a commit-per-commit porting phase with Java
Lucene, please stick to bug fixes, and keep changes to minimal.
Thank you for your understanding and I look forward for more patches.
-- George
> CompoundFileWriter cleanup
> --------------------------
>
> Key: LUCENENET-219
> URL: https://issues.apache.org/jira/browse/LUCENENET-219
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Nicholas Paldino
> Priority: Minor
> Attachments: LUCENENET-219.patch
>
>
> Clean up use of iterators and general use revolving around ids and entries
> (ArrayList and Hashtable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
