[
https://issues.apache.org/jira/browse/LUCENENET-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778213#action_12778213
]
George Aroush commented on LUCENENET-249:
-----------------------------------------
Hi Andrei,
I agree with DIGY. It's very difficult to take a patch like this. May I
suggest the following?
1) Grab the current latest code from the trunk
2) Execute NUnit on the test-cases
3) Grab a failing test and submit a patch for it
Given that you say you got all unit tests to pass, you should be able to bring
over, one patch at a time that addresses each test-case.
Thanks.
-- George
> Many bugs fix patch
> -------------------
>
> Key: LUCENENET-249
> URL: https://issues.apache.org/jira/browse/LUCENENET-249
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Iliev Andrei
> Attachments: comprehensive.patch, lucene2.9.0fixed.zip
>
>
> All Nunit test are passed (actually, some tests fail if run the whole tests
> but does not fail if runned individulally. probably it is related with Nunit
> itself),
> except for:
> 1) Lucene.Net.Index.TestDeletionPolicy.TestKeepAllDeletionPolicy
> commits.Count=15 but was expected 14
> 2) Lucene.Net.QueryParsers.TestQueryParser.TestCJK:
> Shoud be yeasly fixed for Japanese people.
> 3)3 tests in Lucene.Net.Search.Function.TestCustomScoreQuery
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreFloat:
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreInt:
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreShort:
> Slight difference with the expected scores.
> Some notes:
> 1) Added support for java NIO (I ported java ByteBuffer/CharBuffer) -> new
> directory JavaSupport.
> 2) Added new classes in SupportClass.cs
> I think it is time to put all support classes in files in separate directory
> (ex. JavaSupport). What do you think about it?
> 3) I found that some public methods in DateTools that accept long time
> argument, does not use it as milliseconds since January 1, 1970, 00:00:00
> GMT (as it is stated in the documentation).
> I think it is not good (it diverges form java lucene). So I fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
