[ 
https://issues.apache.org/jira/browse/LUCENENET-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839194#action_12839194
 ] 

Digy commented on LUCENENET-345:
--------------------------------


Hi Mike,

Is WeakKey.Equals correct? (At the end of your patch)

{code}
public override bool Equals(object obj)
{
  if (obj is WeakKey)
  {
      return ((WeakKey)obj).GetHashCode().Equals(this.GetHashCode());
   }
   return false;
}
{code}

Shouldn't it be something like
{code} 
  return ((WeakKey)obj).Target.Equals(this.Target); //maybe some null controls
{code} ? 

DIGY


> [Contrib] Extensions
> --------------------
>
>                 Key: LUCENENET-345
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-345
>             Project: Lucene.Net
>          Issue Type: New Feature
>            Reporter: Michael Garski
>         Attachments: LUCENENET-345 Extensions.patch
>
>
> I have created a few generic extensions to Lucene.Net that I use quiet a bit. 
>  It's packaged up as a VS2008 solution with two projects.  The test project 
> is a Visual Studio test project as opposed to NUnit, and that can be changed. 
>  Here is a summary of the contents:
> FieldEnumerators : provides foreach syntax support when enumerating over all 
> of the terms in the index.
> TermVectorEnumerator : provides foreach syntax to allow for enumerating over 
> all of the term vectors in an index.
> BooleanFilter : combine multiple query filters in various logical 
> combinations.
> TermsFilter : creates a filter from several terms as a logical OR.
> SegmentCache : a generic cache that works with the segment-level searching in 
> Lucene 2.9 to cache any data at the segment level in the same manner as the 
> field cache and  CachingWrapperFilter which  I've used for caching aggregate 
> data on the documents in a segment for use in diagnostics and for caching 
> TermVectors.  
> SegmentsGenCommit : adds the ability to open an index from the version 
> specified in the segments file as opposed to inferring the version from the 
> files in the index directory.
> Refer to the documentation comments and unit tests for how to use the items.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to