Marvin Humphrey wrote on 09/18/2010 01:52 PM: > However, I have come to believe that the advantages of succinctness do not > outweigh the disadvantages of inconsistency, and that it would be better to > have all properties default to false.
+1 > Furthermore, by having all properties default to false, we can implement them > as bit-flags and have the C constructors for FieldType subclasses take a > "flags" integer which defaults to 0. +1 > If we change the defaults in Lucy, it will mean a back-compat break with > KinoSearch. However, we can minimize the disruption by consolidating > FullTextType and StringType into a single, new TextType class. Then, when > KinoSearch schema.json files are read and fieldtypes are detected which are > labeled "fulltext" or "string" instead of the new "text", we can just add the > flags and invoke TextType's constructor. > > Since numeric types are not public yet in KS, that leaves only BlobType, which > is rarely used. My thinking is that it probably makes sense to just break > back compat for BlobType. +1 -- Peter Karman . http://peknet.com/ . [email protected]
