Marvin Humphrey wrote on 3/13/11 7:28 PM: > > There are only c. 80 lines of code in smoke.pl; from my perspective, modifying > it to eliminate these dependencies is less work than ascertaining whether our > distribution of a file that uses these modules would be kosher. > > Path::Class - replace with File::Spec::Functions > SVN::Class - replace with system() > JSON::XS - replace with ini-style name=value conf file. > Email::Stuff - replace with Net::SMTP > > I'm happy to work up a patch. The result will be a little less elegant, but > workable.
fine with me. > Unfortunately I can't think of a way to replace the Test::LeakTrace > dependency. Peter, do you feel strongly enough about this test file to do the > research on whether we can ship it with Lucy? My inclination would be to > remove it because unlike Parse::RecDescent and JSON::XS, Lucy can still build > and run without it -- but maybe we should investigate what it tells us first? fine to remove it. I actually find it generating false positives, so not sure it's worth investigation since valgrind works well. -- Peter Karman . http://peknet.com/ . [email protected]
