On Sun, Jan 15, 2012 at 09:35:10PM -0600, Peter Karman wrote:
> For suggestions as to how to evaluate Apache Lucy release candidates, and for
> information on ASF voting procedures, see:
>
> http://wiki.apache.org/lucy/ReleaseVerification
-1
There is a problem in the LICENSE file which I believe we need to correct.
IMO, we should fix that, make a couple updates to CHANGES and reroll.
Going over the ReleaseVerification checklist...
RAT => +1
The RAT report for trunk is stuck, so I ran RAT manually. Things look fine.
Issue tracker clean => +1
No unresolved 0.3.0 issues.
Copyright dates => +1
NOTICE entry has been updated for 2012. No other notices need updating.
CHANGES file => +0
It looks like LUCY-204 and LUCY-205 did not make it into the CHANGES file
because their "Fix version" was updated after Peter generated the CHANGES
entry for 0.3.0. Not a blocker, but we should update CHANGES in both trunk
and branches/0.3.
It would also be nice to start things off with a short summary blurb
advertising the most important user-visible features for 0.3.0. I'm pleased
that we have the CHANGES entry generation automated so that it's easier on
the RM, but I regret that StandardAnalyzer, Normalizer and EasyAnalyzer are
not mentioned prominently. As a community, we could have handled this
better in the runup to 0.3.0.
Review LICENSE and NOTICE => -1
The Unicode data license is present in LICENSE, but the blurb above it
describing where it applies is insufficient. It only mentions utf8proc:
Portions of the utf8proc library are bundled with this distribution under
modules/unicode/utf8proc. The utf8proc library also contains materials
derived from files licensed by the Unicode consortium. Here are the
licenses
for all bundled materials associated with utf8proc:
We need to update LICENSE so that the Unicode data license also applies to
our home-grown Unicode tables and JSON test files under modules/unicode/ucd
are also included. It might be better to do this by being *less* specific
about what files the license applies to. We should also update the
copyright date embedded in the Unicode data license to be either 2011
(reflecting the data at the time Nick generated those files) or 2012.
IMO this is a blocker, because there is *no* other licensing information for
modules/unicode/ucd/WordBreakTest.json as JSON files cannot contain
comments.
Portability => +0
I didn't repeat my Windows tests, but I assume everything still works.
Extended tests => +0
I didn't run test_valgrind, but I assume it's still OK.
Signatures and sums => +1
Everything looks good:
marvin@smokey:~/Desktop/lucy030 $ gpg --verify
apache-lucy-incubating-0.3.0.tar.gz.asc
gpg: Signature made Sun Jan 15 19:31:00 2012 PST using RSA key ID 4A7DB092
gpg: Good signature from "Peter Karman (CODE SIGNING KEY)
<[email protected]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 52CF C03E D308 A026 33B2 4258 2625 1987 4A7D B092
marvin@smokey:~/Desktop/lucy030 $ gpg --print-md md5
apache-lucy-incubating-0.3.0.tar.gz
apache-lucy-incubating-0.3.0.tar.gz: B2 3A 54 19 50 8C A6 2A 17 AF 7B A5
B2 77
84 6B
marvin@smokey:~/Desktop/lucy030 $ cat
apache-lucy-incubating-0.3.0.tar.gz.md5
b23a5419508ca62a17af7ba5b277846b apache-lucy-incubating-0.3.0.tar.gz
marvin@smokey:~/Desktop/lucy030 $ gpg --print-md sha512
apache-lucy-incubating-0.3.0.tar.gz
apache-lucy-incubating-0.3.0.tar.gz: 6686C56F CD3965F6 DAA524BB 6651246C
DFAB8EB8 801FA32E 34888A7C 0E371746
13593596 3F13C410 4BD5C2AE 04B99522
258FBB2F EEAD54D3 8DA90D9E 96C7416A
marvin@smokey:~/Desktop/lucy030 $ cat
apache-lucy-incubating-0.3.0.tar.gz.sha
6686c56fcd3965f6daa524bb6651246cdfab8eb8801fa32e34888a7c0e371746135935963f13c4104bd5c2ae04b99522258fbb2feead54d38da90d9e96c7416a
apache-lucy-incubating-0.3.0.tar.gz
Building and testing => +1
Built and tested fine with the stock Perl 5.10.0 on OS X Snow Leopard.
Downstream artifacts => +1
I built the CPAN dist. All critical files were included, the package built,
and all tests passed.
Marvin Humphrey
