On 25/03/2012 20:33, Marvin Humphrey wrote:
On Sat, Mar 24, 2012 at 4:37 AM, Nick Wellnhofer<[email protected]>  wrote:

One thing is core/Lucy/Util/ToolSet.h, which is included from every
Clownfish .c file. I'm not sure what's the best way to handle that.

For the record, I grepped trunk/clownfish for "ToolSet" and came up empty.  I
believe it's used only in Lucy-specific hand-coded .c files in core/, not in
CFC-autogenerated files.  Right?

Yes, it's just a utility file used in the Lucy .c files.

Nevertheless, there is still a potential problem in that .cfh files are
allowed to contain arbitrary C code, and this scenario could have arisen:

     class Lucy::Foo::Bar {
         ...
     }

     __C__
     #include "Lucy/Util/ToolSet.h"
     __END_C__

To address that scenario, I believe that the best approach is to install all
.h files in core/ along with all .cfh files underneath Clownfish/_include.

OK, makes sense.

Nick

Reply via email to