On 25/03/2012 20:57, Marvin Humphrey wrote:
On Sat, Mar 24, 2012 at 4:13 AM,<[email protected]>  wrote:
Author: nwellnhof
Date: Sat Mar 24 11:13:46 2012
New Revision: 1304766

URL: http://svn.apache.org/viewvc?rev=1304766&view=rev
Log:
Always include ZombieCharBuf and VTable in parcel.c

Extensions need them

Sorry, that wasn't very clear.

If extensions need ZombieCharBuf and VTable header files, that's cool -- but
if they need the struct definitions, that's a bug.

+        "#define C_LUCY_ZOMBIECHARBUF\n"
+        "#define C_LUCY_VTABLE\n"
         "%s\n"
         "#include \"parcel.h\"\n"
+        "#include \"Lucy/Object/CharBuf.h\"\n"
+        "#include \"Lucy/Object/VTable.h\"\n"

It's not the extensions that need the struct definitions, it's the code in parcel.c:

/* Define the variable which holds this class's class name.
 */

static cfish_ZombieCharBuf LUCY_QUERY_CLASS_NAME = {
    CFISH_ZOMBIECHARBUF,
    {1}, /* ref.count */
    "Lucy::Search::Query",
    19,
    0
};

When building Lucy, CharBuf and VTable are automatically included with struct definitions. But in extensions this is not the case.

Nick

Reply via email to