[
https://issues.apache.org/jira/browse/LUCY-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782959#action_12782959
]
Marvin Humphrey commented on LUCY-72:
-------------------------------------
OK, now that we have the fiddly stuff straightened out...
This is a good patch. It takes the intent of the original task and goes much
farther in exactly the right direction. With this patch, it is much clearer
where you might find all the various functions being invoked within
Charmonizer, and we are much more in line with the namespacing conventions
used in the Lucy core.
The only thing that's a little wacky is that charmonize.c itself was supposed
to be user code, and thus maybe ought to be using the full qualified symbols
as we'd expect user code to do.
I think that wasn't clear because of where charmonize.c is located, right
there in trunk/charmonizer/. Nate thought it was internal to Charmonizer,
too. And if you both made the same "mistake" from my perspective, then we
know who's *really* to blame. :)
Maybe what we should do is move this full-on version of charmonize.c somewhere
else (trunk/core?), add a trunk/charmonizer/sample/ directory and include a
slimmed-down version that's obviously documentation rather than functional
code in use by Lucy. Whatever. That's a separate issue, and we should
discuss it on the dev list as we decide what kind of an API Charmonizer ought
to have and how to document it.
In any case, I'm going to make a few more minor mods, break out the
charmonize.c changes as a separate patch, and commit the rest.
> use short names wherever CHAZ_USE_SHORT_NAMES is in effect
> ----------------------------------------------------------
>
> Key: LUCY-72
> URL: https://issues.apache.org/jira/browse/LUCY-72
> Project: Lucy
> Issue Type: Task
> Components: Charmonizer
> Reporter: Peter Karman
> Attachments: chaz_prefix-cleanup.patch, chaz_prefix-cleanup.patch
>
>
> Function names in .c files always use "short names"
> whenever the "LUCY_USE_SHORT_NAMES" macro is in effect -- e.g. we use
> "Sort_mergesort" rather than "lucy_Sort_mergesort".
>
> Within Charmonizer, we should be consistent about using short names
> everywhere the "CHAZ_USE_SHORT_NAMES" macro is in effect, but currently
> there are lots of places that we don't -- e.g. we use "chaz_Test_plan"
> rather than "Test_plan" within charmonizer/src/Charmonizer/Test.charm:
> void
> -chaz_Test_plan(TestBatch *batch)
> +Test_plan(TestBatch *batch)
> {
> printf("1..%u\n", batch->num_tests);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
