[ 
https://issues.apache.org/jira/browse/LUCY-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marvin Humphrey updated LUCY-141:
---------------------------------

    Attachment: compromises.diff

The attached file, compromises.diff, adapts our C code in 4 places by adding
useless parentheses, in order to thwart AStyle from padding inappropriately
when presented with a cast where the '*' character is involved.  It's
unfortunate that we need this patch, but I think it's pretty harmless.

> Auto-format C code using astyle
> -------------------------------
>
>                 Key: LUCY-141
>                 URL: https://issues.apache.org/jira/browse/LUCY-141
>             Project: Lucy
>          Issue Type: Improvement
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>            Priority: Minor
>             Fix For: 0.1-incubating
>
>         Attachments: 0003-Remove-trailing-whitespace-from-C-code.patch, 
> 0004-Adapt-preprocessor-macros-for-pre-ANSI-style.patch, 
> 0005-Attach-opening-brackets-for-functions-to-end-of-the-.patch, 
> 0006-Break-function-body-opening-lines-when-they-exceed-7.patch, 
> 0007-Break-after-operator-because-astyle-does-not-indent-.patch, astylerc, 
> astylerc, brackets.patch, compromises.diff, lucytidy.pl, run_astyle.pl, 
> whitespace.patch, whitespace_stages.tgz
>
>
> We should consider using the automatic code formatter astyle for 
> our C code.
> Dev list thread: http://s.apache.org/INC

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to