[ 
https://issues.apache.org/jira/browse/LUCY-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096156#comment-13096156
 ] 

Marvin Humphrey commented on LUCY-176:
--------------------------------------

The patch needed a slight modification under the 0.2 branch, since
on trunk we have changed LUCY_INCREF to CFISH_INCREF.

> More INCREF/DECREF symbol collisions under Windows
> --------------------------------------------------
>
>                 Key: LUCY-176
>                 URL: https://issues.apache.org/jira/browse/LUCY-176
>             Project: Lucy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.2.0 (incubating), 0.2.1 (incubating)
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.2.2 (incubating), 0.3.0 (incubating)
>
>         Attachments: LUCY-176.patch
>
>
> In LUCY-167, we fixed the INCREF/DECREF symbol collisions in FSDirHandle.c,
> but there were others lurking elsewhere that were missed because none of our
> test systems had the necessary pattern of header file inclusion to trigger the
> bug.  As before, we need to swap out INCREF/DECREF for
> CFISH_INCREF/CFISH_DECREF to avoid colliding with the symbols exported by
> windows.h.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to