[
https://issues.apache.org/jira/browse/LUCY-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153312#comment-13153312
]
Marvin Humphrey commented on LUCY-148:
--------------------------------------
Thanks, Logan -- applied as r1203939.
Nice job disentangling ProximityCompiler_highlight_spans -- that's exactly the
kind of refactoring that I was hoping to see. That function has multiple
iterator variables, some of which hold their state over multiple blocks and
some of which do not. By scope-limiting the local loop iterators, we make it
clear that any iterators with a larger scope have that larger scope
intentionally.
> Mix declarations and code
> -------------------------
>
> Key: LUCY-148
> URL: https://issues.apache.org/jira/browse/LUCY-148
> Project: Lucy
> Issue Type: Sub-task
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: c99_patch01.patch, c99_patch02.patch
>
>
> Much of Lucy was originally written for C89, and uses the C89 idiom of
> declaring all variables at the top of a scope and then assigning to them
> later. Often, this is not ideal code layout, and it would be clearer to
> declare the variable at the same time as it is initialized to a value.
> The following command will reveal many candidates for review.
> {noformat}
> $ grep -r "^ \+[A-Za-z_0-9]\+[ *]\+[a-z0-9_]\+[;,]" lucy \
> > | grep -v "\<return\>" \
> > | grep -v -e "svn\|charmonizer\|modules\|\.pm"
> {noformat}
> LUCY-146 can be considered a specific case of this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
