Hi Solofo, On Mon, Jan 08, 2007 at 01:34:13PM +0100, [EMAIL PROTECTED] wrote:
> Why is it decimal? (as opposed to hexadecimal, ascii...) > For example, "1234" could be replaced by "DOC ". Humans are generally more comfortable with decimal numbers, and the goal of this task is to make things friendlier to humans. > > Messages are of the form: Lustre [ID 1234]: MESSAGE > > What is the need for "ID" and the brackets? > Would it be ok to use > Lustre 1234: MESSAGE > instead? > (without brackets, space and "ID") I think it looks better, and it clearly indicates that 1234 is a message ID and not something else like a PID or a return code. I think that's worth 5 characters but of course all of this is up for discussion - does anyone else have an opinion? > This is 5 chars less, which may be used for something else, e.g. longer > identifiers. > > > Is there an (implicit) 80 chars per line constraint? No. I realize many current kernel messages are limited to 80 characters, but I don't want to impose such a limit since it may compromise readibility. However, all things being equal, shorter messages are preferable. > > EXAMPLE MESSAGES: > [...] > > Lustre [ID 1234]: Server handling error on server [EMAIL PROTECTED]: > > transaction 11602746/0, opcode 42 returned -2 > > Supposing messages are long, would this be: > Lustre [ID 1234]: Server handling error on server [EMAIL PROTECTED]: > Lustre [ID 1234]: transaction 11602746/0, opcode 42 returned -2 > or does the identifier appears only on the first line of the MESSAGE? No. I'm not proposing to line-wrap messages. One of the example messages was wrapped by my editor in the proposed format - I will clarify this in future versions of the document. Lustre [ID 1234]: Server handling error on server [EMAIL PROTECTED]: transaction 11602746/0, opcode 42 returned -2 Cheers, Jody > > > -- > [EMAIL PROTECTED] | Tel: +33 (0)4 76 29 72 48 > Bull SAS, Linux R&D, HPC/CI/Lustre | Fax: +33 (0)4 76 61 52 52 > 1, Rue de Provence. BP208 | Office B1/386 > 38432 Echirolles Cedex, France | Mail Stop B1/167 > -- _______________________________________________ Lustre-devel mailing list [email protected] https://mail.clusterfs.com/mailman/listinfo/lustre-devel
