> On Mon, Sep 7, 2009 at 6:49 PM, Kieran Mansley<[email protected]> wrote: > > On Mon, 2009-09-07 at 18:05 +0530, Mandeep Sandhu wrote: > >> Hi All, > >> > >> I have a question on the function ip_addr_isbroadcast(): > >> > >> Why do we check for destination address even before we've determined > >> if the network interface supports broadcast or not? Shouldn't that be > >> the first check? > > > > I don't know. To be honest, I'm a bit surprised the second check is > > there (and that the function takes a netif as argument at all). It > > would make more sense to be that the function that tests if the address > > is broadcast just tests the address, not the interface properties as > > well. > > Isn't the netif being used to determine if the passed address fits in > as a subnet broadcast address?
Exactly. And I think the function is OK like it is as it first checks whether it is a known broadcast address and then checks whether it is netif-specific one (and returns false if it cannot do this check because the netif doesn't support it). Simon -- GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01 _______________________________________________ lwip-users mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/lwip-users
