Hallo Simon,
regarding cache:
the option
#define MEMP_SEPARATE_POOLS 1 // for PBUF_POOL
alignment to cache line size
is set in lwipopts.h
also
there is following line in cc.h:
extern u8_t memp_memory_PBUF_POOL_base[] __attribute__ ((aligned (32)));
I checked the address of memp_memory_PBUF_POOL_base it is 32byte aligned.
But must only the memp_memory_PBUF_POOL_base be the 32byte aligned or
must also be the
PBUF_POOL_BUFSIZE have a size of multiple of 32 then?
Best regards,
Sandra
here's a extract of a discussion about that from Stephane at 2012:
Hi,
I need 32 bytes alignement on Blackfin for L1 cache
and even 128 bytes on C674x for L2 cache.
I just add this in my cc.h:
// PBUF_POOL needs to be aligned to cache line size
#ifndef __cplusplus
extern u8_t memp_memory_PBUF_POOL_base[] __attribute__ ((aligned (32)));
#endif
And in my lwipopts.h:
#define PBUF_POOL_BUFSIZE 1520
// + sizeof(pbuf) = 1536 = 48 cache lines
But I agree it could be easier with something like:
#define PBUF_ALIGNMENT 32
--
Stephane
Sandra,
I'm afraid problems like yours happend often in the past and only seldom
there has actually been a problem in lwIP. Most of the time, it's wrong
usage of lwIP (by the lwIP port).
Now I don't know the zero copy driver from Stephane, but zero copy
imposes some special requirements on alignment due to cache line size -
maybe you have a problem there? (Unless your system has no data cache,
of course - I don't know the Blackfin...)
Simon
Sandra Gilge wrote:
Hallo,
I'm using the LWIP stack for a kind of SIP-Phone application on Blackfin
BF527 and BF561 with VDK Operating System
I use the zero copy driver implemented by Stephane Lesage.
I currently use a GIT version from 2016-04-05 (2.0 was not released then)
It works well most of the time. But (at heavy load? Or just accidentally? I
think both on heavy load it happens more often) the tcp_input fails because
the pcb queue is corrupted.
There are several possible kinds the error shows:
- Either there is an endless loop because the queue reference to a previous
pcb (the queue is a ring then)
- Assert because the status of the PCB is not as expected (for example the
pcb is in the tw list but the status is not TIME_WAIT: tcp_input: TIME-WAIT
pcb->state == TIME-WAIT)
The error seems to be always in the TCP reception part (mainly when all
TCP_PCB are used, see stats below)
I checked really thoroughly if I (or the driver) do calls of callback-style
API functions outside the TCPIP Stack. But I don't see any calls from
outside TCP Stack!
But the implementation of the driver is not completely as proposed by LWIP.
But in my opinion it should be ok.
Here are the relevant lines in the code:
bfemac_init:
bfemac_txmsg = tcpip_callbackmsg_new(bfemac_tx_callback, netif);
bfemac_rxmsg = tcpip_callbackmsg_new(bfemac_rx_callback, netif);
for (i=0; i<RX_DESCRIPTORS; i++)
{
rxdescriptor[i].packet = pbuf_alloc(PBUF_RAW, 1520, PBUF_POOL);
//alloc pbufs for later use
}
RX-Interrupt:
tcpip_trycallback(bfemac_rxmsg);
TX-Interrupt:
tcpip_trycallback(bfemac_txmsg);
bfemac_rx_callback:
ethernet_input(p, netif); //forward the packet to the
stack (pbuf should be then deallocated by the stack
bfemac_alloc_rxdesc(rxdesc); //get a new pbuf for
further reception
low_level_output:
// DMA supports only one contiguous packet buffer
if (p->next)
{
q = pbuf_alloc(PBUF_RAW, p->tot_len, PBUF_RAM);
if (!q) return ERR_MEM;
pbuf_copy(q, p);
}
else
{
// Increment reference count because we queue the packet to
the DMA chain and return immedialety
// After transmission complete, the interrupt callback will
free the pbuf
pbuf_ref(q);
}
//Then it is appended to the TX descriptor for sending
bfemac_tx_callback:
pbuf_free(txdesc->packet);
Does anybody see a problem in this kind of implementation, or could there be
other reasons for the pcb-chain to be corrupted?
The application strictly uses the sockets api (each thread has its own
sockets).
Best regards,
Sandra
_______________________________________________
lwip-users mailing list
lwip-users@nongnu.org
https://lists.nongnu.org/mailman/listinfo/lwip-users
------------------------------
Message: 4
Date: Wed, 25 Jan 2017 20:49:37 +0100
From: "goldsi...@gmx.de" <goldsi...@gmx.de>
To: Mailing list for lwIP users <lwip-users@nongnu.org>
Subject: Re: [lwip-users] How to force-close a netconn from the server
side?
Message-ID: <58890151.4010...@gmx.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Freddie Chopin wrote:
[..]
Is there any other way than direct messing
with the tcp_pcb to set SOF_REUSEADDR in the so_options field? Maybe
I'm doing something wrong here (except force-closing the client
connections (; )?
In "specialities" like this one, the netconn API is (unfortunately)
sometimes incomplete as the "core" and socket APIs are more widely used.
While you don't have to "mess" with the "so_options" field, you'd have
to call "ip_set_option(conn->pcb.ip, optname)", which should work for
you but is still not a clean solution as accessing the "pcb" member of a
netconn should not be done by client code and should not be done from an
application thread (only from tcpip_thread).
Simon
------------------------------
Message: 5
Date: Wed, 25 Jan 2017 20:02:16 +0000
From: Neerav Patel <neeravpa...@hotmail.com>
To: Mailing list for lwIP users <lwip-users@nongnu.org>
Subject: Re: [lwip-users] Assertions when using DHCP when using LWIP
2.0
Message-ID:
<mwhpr13mb103919e2cf28928e4de6392da8...@mwhpr13mb1039.namprd13.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
The assertion in function: dhcp_create_msg line 1795, my assertion line code
may be off, but I have debugged it down to that. That line is in lwip 2.0.1
and lwip2.0.0RC2, I am using lwip2.0.0RC2.
Thanks
________________________________
From: lwip-users <lwip-users-bounces+neeravpatel=hotmail....@nongnu.org> on behalf of
goldsi...@gmx.de <goldsi...@gmx.de>
Sent: January 25, 2017 7:19 PM
To: Mailing list for lwIP users
Subject: Re: [lwip-users] Assertions when using DHCP when using LWIP 2.0
Neerav Patel wrote:
[..]
and that is when I get:
Assertion "dhcp_create_msg: dhcp->p_out == NULL" failed at line 1774 in
src/core/ipv4/dhcp.c
Assertion "dhcp_create_msg: dhcp->msg_out == NULL" failed at line 1775 in
src/core/ipv4/dhcp.c
In 2.0.0, there are no asserts on those lines.
Simon
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.nongnu.org/archive/html/lwip-users/attachments/20170125/d8e1fc9f/attachment.html>
------------------------------
Subject: Digest Footer
_______________________________________________
lwip-users mailing list
lwip-users@nongnu.org
https://lists.nongnu.org/mailman/listinfo/lwip-users
------------------------------
End of lwip-users Digest, Vol 161, Issue 21
*******************************************
_______________________________________________
lwip-users mailing list
lwip-users@nongnu.org
https://lists.nongnu.org/mailman/listinfo/lwip-users
