The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/5489
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
The stdin channel from WebsocketSendStream needs to be consumed,
otherwise that goroutine will leak.
Signed-off-by: Stephen Barber <smbar...@chromium.org>
From e2379cf367ef76f1b42f5a747c475c18cbdf6cac Mon Sep 17 00:00:00 2001
From: Stephen Barber <smbar...@chromium.org>
Date: Tue, 12 Feb 2019 17:15:33 -0800
Subject: [PATCH] client: fix goroutine leak in ExecContainer
The stdin channel from WebsocketSendStream needs to be consumed,
otherwise that goroutine will leak.
Signed-off-by: Stephen Barber <smbar...@chromium.org>
---
client/lxd_containers.go | 1 +
1 file changed, 1 insertion(+)
diff --git a/client/lxd_containers.go b/client/lxd_containers.go
index b48a154336..0e3e1cd7a8 100644
--- a/client/lxd_containers.go
+++ b/client/lxd_containers.go
@@ -806,6 +806,7 @@ func (r *ProtocolLXD) ExecContainer(containerName string,
exec api.ContainerExec
if fds["0"] != "" {
args.Stdin.Close()
+ <-dones[0]
}
for _, conn := range conns {
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
