Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 17e68c49cf920fba52e937dcf6e0071035ee7927 https://github.com/lxc/lxc/commit/17e68c49cf920fba52e937dcf6e0071035ee7927 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-12 (Sun, 12 May 2019)
Changed paths: M src/lxc/criu.c Log Message: ----------- criu: Remove unnecessary return after _exit() Since _exit() will terminate, the return statement is dead code. Also, returning -1 from a function with bool as return type is confusing. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: 4d927e7f424acc3002531b10af190a947f123ca0 https://github.com/lxc/lxc/commit/4d927e7f424acc3002531b10af190a947f123ca0 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-12 (Sun, 12 May 2019) Changed paths: M src/lxc/storage/lvm.c Log Message: ----------- lvm: Fix return value if lvm_create_clone fails Returning -1 in a function with return type bool is the same as returning true. Change to return false to indicate error properly. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: cdcaad486806b9c892fe3c050444e65c593c4c06 https://github.com/lxc/lxc/commit/cdcaad486806b9c892fe3c050444e65c593c4c06 Author: Rikard Falkeborn <rikard.falkeb...@gmail.com> Date: 2019-05-12 (Sun, 12 May 2019) Changed paths: M src/lxc/storage/zfs.c Log Message: ----------- zfs: Fix return value on zfs_snapshot error Returning -1 in a function with return type bool is the same as returning true. Change to return false to indicate error properly. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeb...@gmail.com> Commit: 7d4188ce7168d0a7f595590c992961b5dfdb6e39 https://github.com/lxc/lxc/commit/7d4188ce7168d0a7f595590c992961b5dfdb6e39 Author: Christian Brauner <christian.brau...@ubuntu.com> Date: 2019-05-13 (Mon, 13 May 2019) Changed paths: M src/lxc/criu.c M src/lxc/storage/lvm.c M src/lxc/storage/zfs.c Log Message: ----------- Merge pull request #2998 from rikardfalkeborn/fix-returning-non-bool Fix returning -1 in functions with return type bool Compare: https://github.com/lxc/lxc/compare/fa9aa1fabb77...7d4188ce7168 _______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel