The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/6541
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
Some minor comment clarifications and typo fixes.
Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
From 61ee872fa7a0d6d7842a0d7e78ea1e9e29f9db79 Mon Sep 17 00:00:00 2001
From: Thomas Parrott <thomas.parr...@canonical.com>
Date: Tue, 3 Dec 2019 13:52:58 +0000
Subject: [PATCH] lxd/storage/backend/lxd: CreateInstanceFromMigration comments
Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
---
lxd/storage/backend_lxd.go | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lxd/storage/backend_lxd.go b/lxd/storage/backend_lxd.go
index 511f0d9a96..99b2c17243 100644
--- a/lxd/storage/backend_lxd.go
+++ b/lxd/storage/backend_lxd.go
@@ -846,9 +846,13 @@ func (b *lxdBackend) CreateInstanceFromMigration(inst
instance.Instance, conn io
}()
// If the negotiated migration method is rsync and the
instance's base image is
- // already on the host then pre-create the instance's volume
using the locla image
- // to try and speed up the rsync of the incoming volume by
avoiding the new to
+ // already on the host then pre-create the instance's volume
using the local image
+ // to try and speed up the rsync of the incoming volume by
avoiding the need to
// transfer the base image files too.
+ // This is performed in the backendLXD rather than the driver
because the driver
+ // should not have access to the database and we need to do an
image record lookup
+ // in order to perform this optimisation when using storage
drivers that do not
+ // managed their own volumes (such as directory).
if args.MigrationType.FSType == migration.MigrationFSType_RSYNC
{
fingerprint :=
inst.ExpandedConfig()["volatile.base_image"]
_, _, err = b.state.Cluster.ImageGet(inst.Project(),
fingerprint, false, true)
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
