The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/3367

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
From cf88a8279b53e63ab9638175e1fbe8639fcd66e5 Mon Sep 17 00:00:00 2001
From: Thomas Parrott <thomas.parr...@canonical.com>
Date: Thu, 9 Apr 2020 11:35:48 +0100
Subject: [PATCH] src/lxc/network: ipvlan comment and code style tweak

Signed-off-by: Thomas Parrott <thomas.parr...@canonical.com>
---
 src/lxc/network.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lxc/network.c b/src/lxc/network.c
index ef45e98ab5..2a4a476509 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -589,11 +589,11 @@ static int lxc_ipvlan_create(const char *master, const 
char *name, int mode, int
        if (nla_put_u32(nlmsg, IFLA_IPVLAN_MODE, mode))
                return ret_errno(EPROTO);
 
-       /* if_link.h does not define the isolation flag value for bridge mode 
so we define it as 0
-        * and only send mode if mode >0 as default mode is bridge anyway 
according to ipvlan docs.
+       /* if_link.h does not define the isolation flag value for bridge mode 
(unlike IPVLAN_F_PRIVATE and
+        * IPVLAN_F_VEPA) so we define it as 0 and only send mode if mode >0 as 
default mode is bridge anyway
+        * according to ipvlan docs.
         */
-       if (isolation > 0 &&
-           nla_put_u16(nlmsg, IFLA_IPVLAN_ISOLATION, isolation))
+       if (isolation > 0 && nla_put_u16(nlmsg, IFLA_IPVLAN_ISOLATION, 
isolation))
                return ret_errno(EPROTO);
 
        nla_end_nested(nlmsg, nest2);
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to