The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxcfs/pull/425

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
The epoll socket create error message fails to expand errno, leading to log output like this:

```
Sep 02 05:48:46 hex-128c1-pm lxcfs[2952544]: utils.c: 188: wait_for_sock: Failed to create epoll socket: %m
Sep 02 05:48:46 hex-128c1-pm lxcfs[2952544]: utils.c: 244: recv_creds: Timed out waiting for scm_cred: Too many open files
Sep 02 05:48:46 hex-128c1-pm lxcfs[2057266]: utils.c: 188: wait_for_sock: Failed to create epoll socket: %m
Sep 02 05:48:46 hex-128c1-pm lxcfs[2057266]: utils.c: 280: send_creds: Too many open files - Failed getting reply from server over socketpair: 2
```
From a2cc3c1562dff2e58fda024fe40c1162a77dc1ae Mon Sep 17 00:00:00 2001
From: Nick Cleaton <n...@cleaton.net>
Date: Wed, 2 Sep 2020 08:57:12 +0100
Subject: [PATCH] fix epoll create socket error message

Signed-off-by: Nick Cleaton <n...@cleaton.net>
---
 src/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils.c b/src/utils.c
index 710d141..53ed111 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -188,7 +188,7 @@ bool wait_for_sock(int sock, int timeout)
 
        epfd = epoll_create(1);
        if (epfd < 0)
-               return log_error(false, "%s\n", "Failed to create epoll socket: 
%m");
+               return log_error(false, "Failed to create epoll socket: %m");
 
        ev.events = POLLIN_SET;
        ev.data.fd = sock;
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to