The following pull request was submitted through Github. It can be accessed and reviewed at: https://github.com/lxc/lxd/pull/8210
This e-mail was sent by the LXC bot, direct replies will not reach the author unless they happen to be subscribed to this list. === Description (from pull-request) === This was checking a yet to be defined field, effectively never succeeding and breaking non-RBAC authentication on RBAC enabled servers. Signed-off-by: Stéphane Graber <stgra...@ubuntu.com>
From ba9dd29116d7433606f397cc425e4fbff2d0ac33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Graber?= <stgra...@ubuntu.com> Date: Wed, 2 Dec 2020 20:33:21 -0500 Subject: [PATCH] lxd/daemon: Fix bad permission check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was checking a yet to be defined field, effectively never succeeding and breaking non-RBAC authentication on RBAC enabled servers. Signed-off-by: Stéphane Graber <stgra...@ubuntu.com> --- lxd/daemon.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lxd/daemon.go b/lxd/daemon.go index 55727ddcd9..82c9b2f883 100644 --- a/lxd/daemon.go +++ b/lxd/daemon.go @@ -454,11 +454,11 @@ func (d *Daemon) createCmd(restAPI *mux.Router, version string, c APIEndpoint) { return ua, nil } - if r.Context().Value("protocol") == "cluster" { + if protocol == "cluster" { return ua, nil } - if r.Context().Value("protocol") == "tls" { + if protocol == "tls" { return ua, nil }
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel