On Thu, 2 Jan 2003, Leonid Pauzner wrote: > 1-Jan-2003 18:37 Thomas Dickey wrote: > > I put a snapshot of my current patch on > > ftp://invisible-island.net/temp/ > > > which includes LP's HTLine change, modified so it seems to work properly. > > This is still an error, Tom. > Your variant will use (MAX_LINE+epsilon)*(lines in the document) memory, > and this is because the last line is allocated in pool in split_line(). > The last (=unfinished) line should be handled differently > then all the previous (=finished) lines.
I did run the program with find-leaks and with valgrind - neither showed me a problem. There might be some scenario where the program leaks - we can test for that. (Actually there were leaks, not related, in the HTParse.c code iirc). > Please undo this code to dev.12 state again. > > > I'm running short of time, will resume working on Lynx tomorrow. > > Also, there are two letters with my patches of higher priority > which are not found in your '12d' snapshot: They came in while I was debugging this one - tomorrow. > > > > From: "Leonid Pauzner" <[EMAIL PROTECTED]> > > Date: Wed, 1 Jan 2003 16:02:08 +0300 (MSK) > > Subject: Re: lynx-dev valgrind-reverse.log.gz > > > Followups: > > > --ATTACHMENT-- Binary file <www2.dif> > > > --ATTACHMENT-- Binary file <src2.dif> > > (this 'fix' the problems introduced in www.dif and src.dif yesterday) > and > > > From: "Leonid Pauzner" <[EMAIL PROTECTED]> > > Date: Sat, 21 Dec 2002 20:15:13 +0300 (MSK) > > Subject: Re: lynx-dev valgrind-reverse.log.gz > > > Three unrelated patches, against dev.12 > > > (1) define HAVE_ALLOCA for DJGPP > > (2) remove quadratic complexity from insert_blanks_in_line() usage > > with large tables (Stbl). It occasionally cleanup split_line() a bit. > > CPU load anomaly reported by BL. > > (3) ALLOC_IN_POOL, POOL_NEW, POOL_FREE macros now became functions, > > suggested by BL. > > > > p.s. (1) was sent to the list previously; > > (2) was sent previously, now updated. > > > > --ATTACHMENT-- Binary file <htutils.dif> > > Description: for WWW/.../HTUtils.h > > > --ATTACHMENT-- Binary file <q_comple.dif> > > Description: for GridText.c > > > --ATTACHMENT-- Binary file <alloc_in.dif> > > Description: for GridText.c > > > > ; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to [EMAIL PROTECTED] > -- T.E.Dickey <[EMAIL PROTECTED]> http://invisible-island.net ftp://invisible-island.net ; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to [EMAIL PROTECTED]
