On Fri, 23 Jul 1999 02:30:19 +0100, Arnd Hanses wrote:

Reading the patch, I see small mistakes:

1)
diff -p -N -r -U 4 -X excl.tmp src/original/filetools.C
src/modified/filetools.C
--- src/original/filetools.C    Wed May 12 06:51:18 1999
+++ src/modified/filetools.C    Fri Jul 23 01:18:56 1999
@@ -78,8 +78,9 @@ LString SpaceLess(LString const & file)
 {
        LString name = OnlyFilename(file);
        LString path = OnlyPath(file);
        // Substitute chars that LaTeX can't handle with safe ones
+       name.toAsciiPrintable(); /* AHanses: Set bit 0, unset bit >= 5
*/

bit counting in the comment is indeed rubbish, depends on
implementation, though:

+       name.toAsciiPrintable(); /* AHanses: Add 32 if < 32, subtract
127, 255 etc.
                                        if > 127 */

2)
>       // Substitute empty with .
>@@ -818,30 +909,56 @@ LString MakeRelPath(LString const & absp
>               buf = '.';
>       return buf;
> }
> 
>-
> // Append sub-directory(ies) to a path in an intelligent way
> LString AddPath(LString const & path, LString const & path2)
> {
>       LString buf;
>+      
>+#ifdef __EMX__        /* AHanses: Handle DOS-style paths ('\') */
>+      if ( !path.empty() && path != "." && (path != "./" || path !=
                                                           ^^ wrong!
>".\\") )

&& (logical AND must be here. '.\' is DOS-style current)
        corrected:
+       if ( !path.empty() && path != "." && path != "./" 
+               && path != ".\\" )

Sorry,

        Arnd

Reply via email to