Georg Baum wrote:
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes:
I don't need to know. I am just moving code around and this should just
work. I am quite confident actually that it _will_ just work.
OK, suppose it works. Then there is still the problem that this is supposed
to be a cleanup, but obfuscates the code for somebody who knows X
selection better.
Such as you?
Georg, if you have a comment or an abjection, express it better please.
I didn't committed because I know I can't test and I am counting of
knowledgeable people such as you.
It is standard X terminology to request or clear a
selection, so a sensible cleanup IMO would be to rename selectionRequested
to requestSelection and selectionLost to clearSelection.
Well, this new method touch _nothing_ that is related with X11
(following my cleanup). It just returns the current selection. This
method should work for any platform, not only X11.
The clipboard is a bit different, there we have an abstraction over windows
and unix clipboards, so we don't need to follow either terminology too
closely.
No need for X knowledge, just need someone who test if the selection
works or not, that' all.
IMO you need X knowledge if it should be really a cleanup and not arbitrary
code shuffling around.
I think that's an unfair comment Georg. If it is just a question of
naming I am all ears. I've named that getStringSelection() because
that's exactly what it does: return the current selection as a string.
Abdel.
