Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Juergen Spitzmueller wrote:
[EMAIL PROTECTED] wrote:
Author: lasgouttes Date: Tue Sep 19 12:27:11 2006 New Revision:
15065
URL: http://www.lyx.org/trac/changeset/15065 Log: Revert fix to
bug 2423 and replace it by a temporary workaround (that unfix= es
bug 1720)
Please remember that Abdel's fix for qt4 has to be reverted as
well. It causes the same problems.
Abdelrazak> I am lost with all the mails on that subject. Could you
Abdelrazak> please summarize what problems does it cause on for which
Abdelrazak> platform? If it is is only MAC, we should not revert the
Abdelrazak> fix but find instead what causes the problem.
What I propose is to revert
http://www.lyx.org/trac/changeset/14809
which was qt4-only.
But are we sure that it causes problems in 1.5? And if yes, which problem?
Then I will propose a patch that splits FuncRequest::UI into MENU and
TOOLBAR and and change the code
/* In LyX/Mac, when a dialog is open, the menus of the
application can still be accessed without giving focus to
the main window. In this case, we want to disable the menu
entries that are buffer-related.
Note that this code is not perfect, as bug 1941 attests:
http://bugzilla.lyx.org/show_bug.cgi?id=1941#c4
*/
Buffer * buf;
if (cmd.origin == FuncRequest::UI && !owner->hasFocus())
buf = 0;
else
buf = owner->buffer();
to act on FuncRequest::MENU only. This should get us the special Mac
behavior without introducing new bugs.
And fix the disabled toolbar button at the same time?
OK? This is at least my plan for 1.4, but I think it is OK for 1.5 too.
If yes, OK for me.
Abdel.
