On Thu, Sep 28, 2006 at 10:08:54AM +0200, Abdelrazak Younes wrote:
> IMO, it is much cleaner this way. I really dislike these global 
> variable. But the bigger benefit (for me) is that I will know exactly 
> what needs more cleanups in the kernel (src/*).
> 
> >We now get a class (and header
> >file) that will have to include a multitude of other header files. and
> >in cases headerfiles that callers does not need at all.
> 
> Right, initially I didn't want to put these additional headers and use 
> forward declaration but scoped_ptr requires them (MSVC gives errors). We 
> have three solutions here:
> 
> 1) use good old C pointers and manage creation/deletion.
> 1) use good old C pointers in Application.h and static scoped_ptr in 
> Application.C creation/deletion.
> 3) pimpl LyXServer, LyXServerSocket and BufferList.
> 
> Which one do you prefer?

Personally I prefer stand-alone singletons, even if there's a dozen of
them. Adding a 'bald' pimpl usually lead to header requiring not even a
single #include.

Andre'

Reply via email to