Georg Baum wrote:
Am Samstag, 30. September 2006 01:10 schrieb Abdelrazak Younes:
Hello,
This is done by creating two new pure virtual method in LyXView:
init(): initialize menubars and toolbars
setGeometry(): guess what it does? :-)
I am not sure gtk and qt3 compiles but it should be close to.
Yep. The only problem was this nasty signals macro in qt3.
Very good. Thank you.
I noticed that your fix does re-include LyXView.h and WorkArea.h. These
should not be necessary. Also Application_pimpl.h should not be
necessary anymore, I forgot to remove it.
+void QtView::setGeometry(unsigned int width,
+ unsigned int height,
+ int posx, int posy,
+ bool maximize)
I noticed in some of your last commits these large indentations.
Isn't this just because of the extra '+' character in the patch?
Please
either indent function arguments with exactly two tabs:
void QtView::setGeometry(unsigned int width, unsigned int height,
int posx, int posy, bool maximize)
Or with as many spaces as are needed to align with the first argument:
void QtView::setGeometry(unsigned int width, unsigned int height,
int posx, int posy, bool maximize)
I thought that that was what MSVC2005 editor is doing by default. But
I'll check.
Both styles are used in LyX, I don't know which one is preferred, but the
indentation above looks strange.
Looks fine here in my editor. Weird.
Abdel.
