Abdelrazak Younes wrote: > Georg Baum wrote: >> Abdelrazak Younes wrote: >> >>> OK, then, adding a BufferView to the TextPainter construction would make >>> sense. The problem is then that I'll have to add a BufferView argument >>> to InsetBase::plaintext() and that's a _lot_ of work. And I am not sure >>> it is right anyway. >> >> I think it would be right if the text painter would be used. > > But all other plantext() methods won't need it.
Since the entry point to drawT is in MathHullInset and this can only exist in a LyXText one could also consider to test for MathHullInset in LyXText::plaintext() and call MathHullInset::drawT() instead of plaintext(). That would avoid to pass unneeded variables to plaintext(). Now that I think about this I like it more than passing a bv to plaintext(), since even the plaintext methods of math insets do not need it. > And I reckon that those > methods are used, aren't they? Yes, they are used for plain text output. > I was exaggerating a bit. MSVC recursive search and replace works fine > and 30 minutes are usually what it take to do an API change. OK. On Fridays you never know what is real and what is not. Georg
