Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>:
"Asger" == Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:
Asger> Michael Gerz wrote:
/home/software/lyx-trunk/src/rowpainter.C:865: warning: unused
variable `const bool inside'
Asger, is it safe to remove the variable?
Asger> Yes, and you can nuke the nullpainter as well while you are at
Asger> it.
Asger> The nullpainter is no good, because it can not calculate the
Asger> metrics of text, so it's basically useless. It was the cause of
Asger> wrong metrics in the coordcache, which caused all sorts of
Asger> problems.
what did you replace it with?
With the real one.
The problem was that the nullpainter did not compute positions correctly.
If it did so, it would need to use almost the same logic as the real painter
and some (if not most) of its speed advantage would have gone.
Maybe we could have a position-coputing-non-painting nullpainter, but
there's also an option of doing sort of 'lazy' metrics computation for
the off-screen paragraphs. We do need their metrics only for page up/down,
yet compute it always right now.
Andre'
