Abdelrazak Younes wrote:
Hello,

I was investigating what is going wring with text selection and I came across a big #if 0. Svn blame tells me that:

At revision 9325, abraunst duplicated the LyXText::drawSelection() method and commented out the first version.

This was the "CoordBranch merge" and it seems that he did duplicate the method as a backup in case something goes wrong afterward.

Conclusion 1: I will commit now.

Conclusion 2: please people, resist the temptation of "#if 0" in SVN code. You can do it as much as you want in your local tree but _not_ in the official tree.

Abdel.

Reply via email to