Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes:
> > I wonder if this addToToc() method is a good idea at all... I'd prefer 
> > the TocBackend to it himself. InsetInclude doesn't need to know how to 
> > do that. The same goes for InsetFloat and InsetWrap I guess.

It is a good idea IMO. Nothing outside of InsetWrap etc. should need to 
know how InsetWrap etc. works. addToToc() is a clean solution IMO: Any 
inset that has to add something to the ToC can implement it, and fill the 
list.

> Here is a patch that does that for InsetInclude. This is cleaner IMHO 
> even if the special cases in TocBackend are still ugly.

I like the solution with addToToc better. In general we tried to remove as 
much as possible special inset casing. All inset knowledge should be 
inside the insets.


Georg

Reply via email to