On Wednesday 15 November 2006 4:03 pm, Jean-Marc Lasgouttes wrote:
> I'd use case instead to avoid portability problems. Something like
> (untested)
>
> lyx_devel_version=no
> lyx_prerelease=no
> case AC_PACKAGE_VERSION in
>   *svn*) lyx_devel_version=yes
>          AC_DEFINE(DEVEL_VERSION, 1, [Define if you are building a
> development version of LyX]) LYX_DATE="not released yet"
>          echo "WARNING: This is a development version. Expect bugs.";;
>   *pre*|*alpha*)lyx_prerelease=yes
>         echo "WARNING: This is a prerelease. Be careful and backup your
> documents.";; esac

  I like this, and it removes 4 lines, this code is more readable so I have 
replaced. Since it works in my tests I have committed it.

> But I suspect we'd better put alpha in the devel camp insetead of pre.
> Do as you prefer.

  I prefer the code this way. :-)

  An alpha release is a release candidate in disguise. ;-)

> JMarc

-- 
José Abílio

Reply via email to