Abdelrazak Younes wrote:

> Georg Baum wrote:
>> Abdelrazak Younes wrote:
>> 
>>> By the way, around section 6.2 of the UserGuide there are some accent
>>> characters which are bigger than 65536.
>> 
>> Which ones? I suspect that something is going wrong there.
> 
> I'll investigate.

Thanks.
 
>>> Shall I add an assertion for
>>> those cases?
>> 
>> Yes.
> 
> But then it would crash...

Of course, but I don't think that reading random stuff from memory is
better.

>> PS: magic numbers are evil
> 
> If these are magic codes for some accent unknown characters when I guess
> I should simply ignore them not assert on them. Am I missing something?

I mean the magic numbers -1000 and 65536 that you added in your patch. No
magic character codes are passed to metrics AFAIK.


Georg

Reply via email to