On Dec 2, 2006, at 4:39 PM, Peter Kümmel wrote:
Bennett Helm wrote:
On Dec 2, 2006, at 12:53 PM, Peter Kümmel wrote:
Bennett Helm wrote:
Yes, please this one.
Well ... I don't notice any difference from the last patch --
including
no crashes to generate a backtrace with.
Bennett
How many ways are there on the Mac to exit the application?
For proper Mac applications, especially those with text windows,
there
are two ways: <Cmd>-q and LyX > Quit. Some applications (including
LyX),
clicking on the red "stoplight" button -- which is supposed to
close the
window -- will quit the application; this is true of LyX as well
(because it only uses one window).
What is the output of LyX when you apply attached patch
for all the ways of exiting?
1. <Cmd>-q:
Program exited normally.
2. LyX > Quit:
Program exited normally.
OK, 1. and 2. shows clearly the problem: no function is
called which we need to save the session & co.
3. Red stoplight:
void GuiView::closeEvent(QCloseEvent * close_event)
Program exited normally.
Bennett
I assume "LyX > Quit" is a menu with the entry Quit.
Yes.
So here a new patch.
That works: in cases (1) and (2) I get:
case LFUN_LYX_QUIT:
void GuiView::close()
void GuiView::closeEvent(QCloseEvent * close_event)
Program exited normally.
In case (3), I get:
void GuiView::closeEvent(QCloseEvent * close_event)
Program exited normally.
Moreover, session info is properly saved now, and quitting with an
unsaved file properly brings up the dialog asking if you want to save.
Well done!
Bennett
