Re: [patch] fix bug 3235 (and a bit more)

[Georg Baum]

Jean-Marc Lasgouttes wrote:

>>>>>> "Georg" == Georg Baum
>>>>>> <[EMAIL PROTECTED]>
>>>>>> writes:
> 
> Georg> Here comes the next mechanical one: Get rid of one of the 100
> Georg> arguments of Paragraph::Pimpl::simpleTeXSpecialChars.
> 
> Very good. What does the patch look like now?

It follows later (still not finished). One bit I am unsure about is this
one: It fixes the problem of a missing \L (so latex does not complain), but
at the same time it messes up the \selectlanguage output.
How would a correct fix would look like?


Georg

3lang.lyx
Description: application/lyx

%% LyX 1.5.0svn created this file.  For more info, see http://www.lyx.org/.
%% Do not edit unless you really know what you are doing.
\documentclass[hebrew,english,greek]{article}
\usepackage[T1]{fontenc}
\usepackage[cp1255]{inputenc}

\makeatletter
\usepackage{babel}
\makeatother
\begin{document}
\selectlanguage{hebrew}
áãé÷ä\L{ greek-test }\L{english-test} áãé÷ä \L{test}\selectlanguage{greek}

\end{document}

%% LyX 1.5.0svn created this file.  For more info, see http://www.lyx.org/.
%% Do not edit unless you really know what you are doing.
\documentclass[english,hebrew,greek]{article}
\usepackage[T1]{fontenc}
\usepackage[cp1255]{inputenc}

\makeatletter
\usepackage{babel}
\makeatother
\begin{document}
\selectlanguage{hebrew}
áãé÷ä\L{ greek-test }\foreignlanguage{english}{english-test} áãé÷ä
\L{test}\selectlanguage{greek}

\end{document}

Index: src/lyxfont.C
===================================================================
--- src/lyxfont.C	(Revision 17443)
+++ src/lyxfont.C	(Arbeitskopie)
@@ -747,7 +747,7 @@ int LyXFont::latexWriteStartChanges(odoc
 	                           *(language()->encoding()));
 	if (language()->babel() != base.language()->babel() &&
 	    language() != prev.language()) {
-		if (isRightToLeft() != prev.isRightToLeft()) {
+		if (isRightToLeft() != base.isRightToLeft()) {
 			if (isRightToLeft()) {
 				os << "\\R{";
 				count += 3;