Richard Heck wrote:
OK, now I've learned about mutable. This seems to be a better patch for
3109. Comments
requested before I commit.
This one is better ;-)
The issue was that the newcolors_ were being checked against prefcolors_
to make sure the color had changed, but prefcolors_ contained the colors
from the preferences file and was not updated when changes were made.
Hence any attempt to revert to the original color was ignored. The
obvious thing to do is:
prefcolors_ = newcolors_
after colors are updated in apply(). As things were, this doesn't work
because apply() is const. So we make prefcolors_ mutable.
I've also renamed prefcolors_ to oldcolors_, as is more compatible with
its new purpose.
OK, looks good. But I don't understand why it worked before for other
colors than black...
Abdel.
