[EMAIL PROTECTED] wrote: > Quoting Andre Poenitz <[EMAIL PROTECTED]>: > > >> On Thu, Mar 29, 2007 at 05:36:54PM -0400, Richard Heck wrote: >> >>> Some discussion with Abdel and my own emerging understanding of what MVC >>> is all about makes it clear that the code needs to be re-organized. The >>> real problem is that there is initialization code in the constructor for >>> PrefColors that is doing two different things: (i) creating the color >>> patches in the dialog and initializing a variable that tracks the >>> current colors. But the constructor is only ever called once, the first >>> time the dialog is created---after that, it exists in memory and is >>> simply recalled when needed---so the existing code never updated the >>> current-colors variable. >>> >> You could set WA_DestructiveClose(sp?) which will destroy the dialog on >> close. Than you get a chance to recreate it later... >> > > Good point. We also could have the pref_colors_ module reinitialised on every > show command but then the vector of modules needs to be reconstructed etc... > Yes, you could do that, but I think a more modular approach to the preferences is justified anyway. > Richard's fix is good enough for now. One question though, did you check that > your fix survives a LyX restart? > Yes, it does. And I've checked it in.
Richard PS Thanks for the help with update etc, Abdel. I'm still studying this. -- ================================================================== Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ ================================================================== Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
