Edwin Leuven wrote:
the attached patch refactors the current toolbarbackend into toolbaritems, toolbar(info) and backend

comments?

The changes look good to me and something that should have been done a long time ago. In 1.6 we should really try to unify toolbar and menu actions.

As for the code, the changes are pretty mechanical, nothing to be afraid of (and testing for correctness is pretty immediate). So, I personally welcome the change but, as you probably know, you will face some resistance so I suggest to list what this cleanup is bringing to the table.

Abdel.

Reply via email to